Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] #224 - 그룹 편집 뷰 서버 연결 #229

Merged
merged 10 commits into from
Dec 26, 2021

Conversation

mini-min
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 그룹 조회 데이터 서버 연결 -> 직접 방식
  • 그룹 삭제 서버 연결 -> 직접 방식
  • 그룹명 변경 서버 연결 -> 클로저 사용
  • 그룹 추가 서버 연결 -> 클로저 사용
  • firstCardID에 첫번째 카드 ID UserDefaults로 저장해두었습니다 ^__^
  • CardListLookUpRequest파일 CardListLookUp으로 네이밍 변경

📮 관련 이슈

@mini-min mini-min added Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음 Feat 새로운 기능 구현 labels Dec 26, 2021
@mini-min mini-min self-assigned this Dec 26, 2021
Comment on lines +29 to +33
override func viewWillAppear(_ animated: Bool) {
super.viewWillAppear(animated)

self.groupEditTableView.reloadData()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동작하지 않는 코드인것 같네용!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 놔두도록 하겠습니다 ^__^

@@ -34,6 +34,7 @@ class FrontViewController: UIViewController {
super.viewWillAppear(animated)

setCardDataModelList()
cardListFetchWithAPI(userID: "nada2", isList: false, offset: offset)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 수정하겠습니닷!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네엡!

Copy link
Member

@dlwns33 dlwns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민재 수고해써용

Comment on lines 153 to 154
// FIXME: - 로그 확인용.
// print("✅cardListLookUpRequest", cardListLookUpRequest)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 혹시 요거 다한건가요! 픽스미 주석 !!

@mini-min mini-min merged commit 3568874 into TeamNADA:release1.0/2 Dec 26, 2021
@mini-min mini-min deleted the release/#224 branch December 26, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 Minjae 🐻‍❄️ 민재 강남1타강사 작업 P1 / Priority High 우선순위 높음
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 그룹 편집 뷰 서버 연결
3 participants